Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hmmalign ported to nf-test, version bump, wave container, standard ou… #6992

Merged
merged 1 commit into from
Nov 14, 2024
Merged

hmmalign ported to nf-test, version bump, wave container, standard ou… #6992

merged 1 commit into from
Nov 14, 2024
+247 −166

Conversation

vagkaratzas
Copy link
Contributor

…tput format, hmmbuild version bump, wave container, subworkflow updated accordingly

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Sorry, something went wrong.

@vagkaratzas
hmmalign ported to nf-test, version bump, wave container, standard ou…
Loading
Loading status checks…
829d23f 
…tput format, hmmbuild version bump, wave container, subworkflow updated accordingly
@vagkaratzas vagkaratzas requested a review from a team as a code owner November 14, 2024 11:09
jfy133
jfy133 approved these changes Nov 14, 2024
View reviewed changes
modules/nf-core/hmmer/hmmalign/tests/main.nf.test
[ id: 'test' ], // meta map
file(params.modules_testdata_base_path + 'delete_me/hmmer/e_coli_k12_16s.fna.gz', checkIfExists: true)
]
input[1] = file(params.modules_testdata_base_path + 'delete_me/hmmer/bac.16S_rRNA.hmm.gz', checkIfExists: true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be because I'm looking from my phone but is this too indented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, shows properly on PC

@vagkaratzas vagkaratzas added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit 03a9f35 Nov 14, 2024
23 checks passed
@vagkaratzas vagkaratzas deleted the hmmer_tools branch November 14, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133

@adamrtalbot adamrtalbot

Assignees
No one assigned
Labels
None yet
Projects
Seqera Containers
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vagkaratzas @jfy133