Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public_aws_ecr.config and use in CI tests #157

Merged
merged 9 commits into from
May 15, 2023
Merged

Add public_aws_ecr.config and use in CI tests #157

merged 9 commits into from
May 15, 2023

Conversation

drpatelh
Copy link
Member

See fo reference: nf-core/smrnaseq#246

@github-actions
Copy link

github-actions bot commented May 13, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f510057

+| ✅ 149 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   6 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • nextflow_config - Config manifest.version should end in dev: '1.10.0'
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-14 20:09:52

@drpatelh drpatelh requested a review from adamrtalbot May 13, 2023 20:11
@drpatelh
Copy link
Member Author

Need to test this actually works. Matbe we can do it via the workflow dispatch from dev when it is merged 🤔 Can't remeber whether the Actions needs to be merged to master or not. Anyhow, hopefully the changes in the PR look good.

@drpatelh drpatelh mentioned this pull request May 14, 2023
Merged
@drpatelh
Copy link
Member Author

Tests failing because we need the PR below adding GEO support to be merged in first:
#155

Will merge this in for now because tests will need to be re-run on those PRs again anyway.

@drpatelh drpatelh merged commit 719dde4 into nf-core:dev May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot adamrtalbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drpatelh @adamrtalbot