Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template update nf-core tools v2.13.1 #117

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Template update nf-core tools v2.13.1 #117

merged 11 commits into from
Mar 19, 2024

Conversation

Daniel-VM
Copy link
Contributor

@Daniel-VM Daniel-VM commented Mar 19, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR description

Update and merge of nf-core template update v2.13.1 (#114 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5ceb33c

+| ✅ 174 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-19 15:09:22

@Daniel-VM Daniel-VM changed the title Dev Template update nf-core tools v2.13.1 Mar 19, 2024
@Daniel-VM Daniel-VM marked this pull request as ready for review March 19, 2024 10:15
@Daniel-VM Daniel-VM mentioned this pull request Mar 19, 2024
Closed
10 tasks
FriederikeHanssen
FriederikeHanssen approved these changes Mar 19, 2024
View reviewed changes
Copy link

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

jonasscheid
jonasscheid reviewed Mar 19, 2024
View reviewed changes
main.nf Outdated Show resolved Hide resolved
jonasscheid
jonasscheid requested changes Mar 19, 2024
View reviewed changes
Copy link

@jonasscheid jonasscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀 ! Just update the tool citations and you are good to go!

subworkflows/local/utils_nfcore_bacass_pipeline/main.nf Show resolved Hide resolved
subworkflows/local/utils_nfcore_bacass_pipeline/main.nf Show resolved Hide resolved
subworkflows/local/utils_nfcore_bacass_pipeline/main.nf Show resolved Hide resolved
jonasscheid
jonasscheid approved these changes Mar 19, 2024
View reviewed changes
Copy link

@jonasscheid jonasscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Always good to give the tools their credit!

@Daniel-VM
Copy link
Contributor Author

Thank you!!! Yes, I completely forgot about that crutial part of the new version of the nf-core template.

@Daniel-VM Daniel-VM merged commit 6265523 into nf-core:dev Mar 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasscheid jonasscheid jonasscheid approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Daniel-VM @FriederikeHanssen @jonasscheid @nf-core-bot