authn: Resave an on-the-fly updated user object back to the stored session #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion Rather than perpetually updating it on-the-fly with every request. Resolves a downside of "authn: Upgrade existing sessions which pre-date addition of authzRoles" (272ed09) and was simpler to implement than I thought!
0d2a4ea to
4225fcf
Compare
joverlee521
approved these changes
Mar 7, 2022
| // the user object in the session via req.login(). The session will detect | ||
| // its been changed and save itself to the store at the end of the request. | ||
| app.use((req, res, next) => { | ||
| if (req.user?.[RESAVE_TO_SESSION]) { |
There was a problem hiding this comment.
Wow, didn't know optional chaining was a thing! 🤓
There was a problem hiding this comment.
We couldn't use it here until the recent version bump from Node 13 → 14, so it's a nice perk of that! In the same family is also ??, the "nullish coalescing operator".
|
Deployed and working: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than perpetually updating it on-the-fly with every request.
Resolves a downside of "authn: Upgrade existing sessions which pre-date
addition of authzRoles" (272ed09) and was simpler to implement than I
thought!
Related issue(s)
Related to #479 and #452.
Testing
I tested locally (which uses a file-based session store) by first acquiring an "old" session (i.e. logging in on an earlier version of the codebase), which contained a user object like:
then I restarted my local server with the code in this PR and made another request, after which my session contained the expected updates: