Use centralized scripts with S3 interactions #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joverlee521
reviewed
Aug 8, 2023
This was referenced Aug 9, 2023
subrepo: subdir: "ingest/vendored" merged: "1eb8b30" upstream: origin: "https://github.com/nextstrain/ingest" branch: "main" commit: "1eb8b30" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"
bf3c93a to
579e31b
Compare
The first argument was updated to take an owner/repo pair¹. ¹ nextstrain/ingest@89b0da2
Remove the copies in this repo and update references.
The centralized version includes new args which requires changes in this repo¹. ¹ nextstrain/ingest@065cc2f
579e31b to
02d6119
Compare
joverlee521
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The "Files changed" tab doesn't provide a useful diff since the vendored scripts were added as part of #166. 79e690f...02d6119 is a more useful diff that detects the script replacements as renames.
Description of proposed changes
Updating to use new scripts added to central ingest in nextstrain/ingest#12.
Related issue(s)
Testing
Ingest runs locallySkipping as this wouldn't test any of the changes#monkeypox-updatesare normal