Skip to content

Commit

Permalink
Use centralized scripts for NCBI Virus
Browse files Browse the repository at this point in the history
`fetch-from-ncbi-virus` from the subrepo is a copy of
`fetch-from-genbank` with some extra options. It can be used as-is since
the new options are not required. Remove the copy in this repo and
update references.

The supporting scripts `csv-to-ndjson` and `genbank-url` can also be
removed.
  • Loading branch information
victorlin committed Aug 30, 2023
1 parent 378c524 commit 111020e
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 132 deletions.
2 changes: 1 addition & 1 deletion ingest/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ These are optional environment variables used in our automated pipeline for prov
### GenBank data

GenBank sequences and metadata are fetched via NCBI Virus.
The exact URL used to fetch data is constructed in `bin/genbank-url`.
The exact URL used to fetch data is constructed by `vendored/ncbi-virus-url`.

## `ingest/vendored`

Expand Down
17 changes: 0 additions & 17 deletions ingest/bin/csv-to-ndjson

This file was deleted.

22 changes: 0 additions & 22 deletions ingest/bin/fetch-from-genbank

This file was deleted.

91 changes: 0 additions & 91 deletions ingest/bin/genbank-url

This file was deleted.

2 changes: 1 addition & 1 deletion ingest/workflow/snakemake_rules/fetch_sequences.smk
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ rule fetch_from_genbank:
retries: 5 # Requires snakemake 7.7.0 or later
shell:
"""
./bin/fetch-from-genbank 10244 > {output.genbank_ndjson}
./vendored/fetch-from-ncbi-virus 10244 > {output.genbank_ndjson}
"""


Expand Down

0 comments on commit 111020e

Please sign in to comment.