net: Don't consider a host that we can't resolve as having a loopback address #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… address Our is_loopback() implements three-valued logic (True, False, None) but all() implements boolean logic, so we need to handle the empty case ourself. Oops! Noticed while testing an IPv6-only host against a Python with IPv6 disabled, which made it unresolvable. See "Gracefully handle IPv6 sockaddrs when Python's compiled without IPv6 support" (06e830b).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our is_loopback() implements three-valued logic (True, False, None) but all() implements boolean logic, so we need to handle the empty case ourself. Oops!
Noticed while testing an IPv6-only host against a Python with IPv6 disabled, which made it unresolvable. See "Gracefully handle IPv6 sockaddrs when Python's compiled without IPv6 support" (06e830b).