pyparsing 3.1.0 fix #294
Merged
pyparsing 3.1.0 fix #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rely on the pyparsing 3.0.0 API. It was released well before our first use of it, but still good to cross Ts and dot Is because older pyparsing might be used by other deps in an environment. I had cause to think about this when debugging just now, so fix it up.
The recent release of pyparsing fixed a bug in SkipTo¹ "that has been
there for a very very long time"² and which we were unintentionally
relying upon. The fix caused our parsing of
to break as SkipTo(White()) no longer matched due to our grammar
ignoring whitespace by default. We didn't notice until 3.1.0 was
released a couple days ago.
Explicitly don't ignore whitespace for this grammar element. This
change is backwards compatible with older versions of pyparsing.
Resolves <#293>.
¹ <pyparsing/pyparsing@9d789cbc>
² <pyparsing/pyparsing#475>
|
Well test-source jobs are now passing again, but we're still hitting the stochastic failures of Python 3.7 on macOS (as previously, see also). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
Resolves #293.
Testing