Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell: Ensure the history file always exists #232

Merged
merged 2 commits into from
Nov 1, 2022
Merged

shell: Ensure the history file always exists #232

merged 2 commits into from
Nov 1, 2022

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Nov 1, 2022 •
edited
Loading

Resolves #231.

Testing

@tsibley
Copy link
Member Author

tsibley commented Nov 1, 2022

The easiest way to test this is by setting NEXTSTRAIN_HOME to a directory that doesn't exist and/or a directory that does exist, but is missing a shell-history file.

@tsibley tsibley force-pushed the trs/shell/ensure-history-mount-exists branch from 56bf316 to 1e2f82f Compare November 1, 2022 19:09
@tsibley tsibley marked this pull request as ready for review November 1, 2022 19:09
@tsibley tsibley requested review from joverlee521 and a team November 1, 2022 19:15
@tsibley tsibley mentioned this pull request Nov 1, 2022
Closed
joverlee521
joverlee521 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

The easiest way to test this is by setting NEXTSTRAIN_HOME to a directory that doesn't exist and/or a directory that does exist, but is missing a shell-history file.

Good to know! I totally missed NEXTSTRAIN_HOME was added!

@tsibley tsibley merged commit 5afb5ee into master Nov 1, 2022
@tsibley tsibley deleted the trs/shell/ensure-history-mount-exists branch November 1, 2022 20:47
@tsibley
Copy link
Member Author

tsibley commented Nov 1, 2022

This fix will be released as 5.0.1, currently building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joverlee521 joverlee521 joverlee521 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[shell] shell-history does not exist for Docker
2 participants
@tsibley @joverlee521