remote download: Use more of the resource path in the local filename #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes all of the resource path except for the leading namespace part (if any), e.g. /groups/X or /staging. This reduces the potential for ambiguous filenames and makes it easier to copy datasets/narratives between destinations (e.g. from one group to another) while retaining the same path. It is, however, a **potentially-breaking change** if you're relying on the filenames of the downloaded datasets/narratives (e.g. for automation).
victorlin
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all of the resource path except for the leading namespace part
(if any), e.g. /groups/X or /staging.
This reduces the potential for ambiguous filenames and makes it easier
to copy datasets/narratives between destinations (e.g. from one group to
another) while retaining the same path. It is, however, a
potentially-breaking change if you're relying on the filenames of
the downloaded datasets/narratives (e.g. for automation).
Related issue(s)
Related to #169.
Testing