Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: Extend export v2 schema to support an array of trees #851

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Feb 14, 2022

Supports the new multi-tree or exploded tree features in Auspice, while
maintaining backwards compatibility.

Resolves #848.

Supports the new multi-tree or exploded tree features in Auspice, while
maintaining backwards compatibility.

Resolves #848.
@tsibley tsibley mentioned this pull request Feb 14, 2022
@tsibley
Copy link
Member Author

tsibley commented Feb 14, 2022

@jameshadfield's example JSON file in #848 fails on master but passes on this branch when tested with:

jsonschema -i tree-array-example.json augur/data/schema-export-v2.json

https://data.nextstrain.org/zika.json continues to pass.

@tsibley tsibley marked this pull request as ready for review February 14, 2022 19:37
@tsibley tsibley requested a review from a team February 14, 2022 19:37
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tsibley tsibley merged commit c5b56a7 into master Feb 14, 2022
@tsibley tsibley deleted the trs/schemas/multitree branch February 14, 2022 23:32
@huddlej huddlej added this to the Next release X.X.X milestone Feb 15, 2022
jameshadfield added a commit that referenced this pull request Apr 24, 2024
Multiple trees ("subtrees") have been available in Auspice since late
2021¹ and part of the associated schema since early 2022². Despite this
there was no way to produce such datasets within Augur itself, and
despite the schema changes the associated `augur validate` command was
never updated to allow them.

This commit adds multi-tree inputs to `augur export v2` as well as
allowing them to validate with our associated validation commands.

¹ <nextstrain/auspice#1442>
² <#851>
jameshadfield added a commit that referenced this pull request Apr 24, 2024
Multiple trees ("subtrees") have been available in Auspice since late
2021¹ and part of the associated schema since early 2022². Despite this
there was no way to produce such datasets within Augur itself, and
despite the schema changes the associated `augur validate` command was
never updated to allow them.

This commit adds multi-tree inputs to `augur export v2` as well as
allowing them to validate with our associated validation commands.

¹ <nextstrain/auspice#1442>
² <#851>
@jameshadfield jameshadfield mentioned this pull request Apr 29, 2024
2 tasks
jameshadfield added a commit that referenced this pull request May 6, 2024
Multiple trees ("subtrees") have been available in Auspice since late
2021¹ and part of the associated schema since early 2022². Despite this
there was no way to produce such datasets within Augur itself, and
despite the schema changes the associated `augur validate` command was
never updated to allow them.

This commit adds multi-tree inputs to `augur export v2` as well as
allowing them to validate with our associated validation commands.

¹ <nextstrain/auspice#1442>
² <#851>
jameshadfield added a commit that referenced this pull request May 6, 2024
Multiple trees ("subtrees") have been available in Auspice since late
2021¹ and part of the associated schema since early 2022². Despite this
there was no way to produce such datasets within Augur itself, and
despite the schema changes the associated `augur validate` command was
never updated to allow them.

This commit adds multi-tree inputs to `augur export v2` as well as
allowing them to validate with our associated validation commands.

¹ <nextstrain/auspice#1442>
² <#851>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dataset schema
3 participants