frequencies: Initialize variables in proper scope #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit "Annotate tips with the minimum necessary information" (dde857a) referenced the weights_attribute variable before it was initialized, resulting in an UnboundLocalError when a non-KDE method (i.e. diffusion) is used with --tree. This brings that variable and another related one to a higher scope where the reference is now valid.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
+ Coverage 67.67% 68.39% +0.71%
==========================================
Files 69 69
Lines 7518 7517 -1
Branches 1844 1843 -1
==========================================
+ Hits 5088 5141 +53
+ Misses 2158 2092 -66
- Partials 272 284 +12 ☔ View full report in Codecov by Sentry. |
joverlee521
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
#1398 referenced the
weights_attributevariable before it was initialized, resulting in anUnboundLocalErrorwhen a non-KDE method (i.e. diffusion) is used with--tree. This brings that variable and another related one to a higher scope where the reference is now valid.Related issue(s)
Checklist
--method diffusion