Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #56

Closed
wants to merge 17 commits into from
Closed

Dark mode #56

wants to merge 17 commits into from

Conversation

Josmolmor
Copy link
Contributor

closes #44

Screen.Recording.2024-10-01.at.14.32.54.mp4

Copy link

vercel bot commented Oct 1, 2024

@Josmolmor is attempting to deploy a commit to the leerob-site Team on Vercel.

A member of the Team first needs to authorize it.

@johanguse
Copy link

Would you also be able to add the system mode? The system mode gets the user's OS preferences.....

image

@johanguse
Copy link

johanguse commented Oct 1, 2024

Did you know that there already exists a PR for dark mode #45 ?

@Josmolmor
Copy link
Contributor Author

Josmolmor commented Oct 1, 2024

Would you also be able to add the system mode? The system mode gets the user's OS preferences.....

image

It already checks for user preference https://github.com/leerob/next-saas-starter/pull/56/files#diff-0dc1c925c74b340e65c99acb568aebf3f7b1b4074b3591bb570667ebc49b385cR17

@leerob
Copy link
Collaborator

leerob commented Nov 1, 2024

Going to combine with this PR -> #45

I don't want to do a picker, but instead just use the system settings 👍

@leerob leerob closed this Nov 1, 2024
@syntaxsurge syntaxsurge mentioned this pull request Feb 12, 2025
@syntaxsurge
Copy link

syntaxsurge commented Feb 12, 2025

Going to combine with this PR -> #45

Why? Their solution is different, and I would say that the solution in this PR is better than the one you mentioned. It’s been years, and I can’t believe dark mode is still not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark mode
4 participants