Support Azure Managed Identities in Fusion configuration logic #5278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This commit extends the `AzFusionEnv` class so that it now takes into account a potential Azure Managed Identity in Nextflow's configuration file. It also fixes a configuration error (nextflow-io#5081) by which Nextflow complained of a missing SAS token despite having a Managed Identity properly configured. Signed-off-by: Alberto Miranda <alberto.miranda@seqera.io>
94b164c to
a941835
Compare
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the
nextflow.cloud.azure.fusion.AzFusionEnvclass so that it now takes into account a potential Azure Managed Identity in Nextflow's configuration file. This also fixes a configuration error (#5081) by which Nextflow complained of a missing SAS token despite having a Managed Identity properly configured.