-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow usage of custom emojis in pagination #15
Merged
DenverCoder1
merged 10 commits into
nextcord:master
from
DenverCoderOne:custom-emoji-fix
Oct 20, 2021
Merged
Allow usage of custom emojis in pagination #15
DenverCoder1
merged 10 commits into
nextcord:master
from
DenverCoderOne:custom-emoji-fix
Oct 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooliver1
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, tested it myself and fully working
Added support for overriding reaction menu pagination emojis as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button Menus
Changed usages of
emoji.name
tostr(emoji)
since for custom emoji,emoji.name
will return just the name (eg.pagefirst
), butstr(emoji)
will return the full emoji (eg.<:pagefirst:899973860772962344>
).When overriding the emoji, the full emoji will need to be specified, so this allows the use of custom emoji in ButtonMenuPages.
Usage of default emojis has been tested and it still works (it is not affected by this change).
Reaction Menus
Changed usage of
@button
decorator to calls toadd_button
in order to make it possible to use instance properties (eg.self.FIRST_PAGE
) instead of having to useMenuPagesBase.FIRST_PAGE
.Example usage:
Button Menus
Reaction Menus