Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Delete menu-sidebar-white.svg" #476

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Revert "Delete menu-sidebar-white.svg" #476

merged 1 commit into from
Apr 24, 2020

Conversation

skjnldsv
Copy link
Member

This reverts commit 2225b72.

@skjnldsv skjnldsv added regression Regression of a previous working feature design Related to the design 3. to review Waiting for reviews labels Apr 23, 2020
@skjnldsv skjnldsv self-assigned this Apr 23, 2020
@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv
Copy link
Member Author

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Apr 23, 2020
@skjnldsv @npmbuildbot
Revert "Delete menu-sidebar-white.svg"
0158091 
This reverts commit 2225b72.

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@skjnldsv skjnldsv mentioned this pull request Apr 23, 2020
Merged
@cypress
Copy link

cypress bot commented Apr 23, 2020


Test summary

164 • 4 • 0 • 0

Run details
Project viewer
Status Failed
Commit 0158091
Started Apr 23, 2020 3:12 PM
Ended Apr 23, 2020 3:14 PM
Duration 01:55 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 78

View run in Cypress Dashboard ➡️

Failures

images.spec.js ⏯ 1 Failed
1 Open images in viewer > Does not see a loading animation
images-custom-list-loadmore.spec.js ⏯ 1 Failed
1 Open custom list of images in viewer with pagination > Does not see a loading animation
sidebar.spec.js ⏯ 1 Failed
1 Open the sidebar from the viewer and open viewer with sidebar already opened > Does not see a loading animation
images-custom-list.spec.js ⏯ 1 Failed
1 Open custom images list in viewer > Does not see a loading animation

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@skjnldsv skjnldsv merged commit 2876a15 into master Apr 24, 2020
@skjnldsv skjnldsv deleted the revert/icon branch April 24, 2020 06:35
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 24, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #477 with conflicts ⚠️

@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Apr 24, 2020
@rullzer rullzer mentioned this pull request Apr 24, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews design Related to the design regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skjnldsv