-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @nextcloud/vue to 6.0.0 #1319
Conversation
juliusknorr
commented
Aug 11, 2022
•
edited
Loading
edited
- Requires build(deps): bump vue from 2.6.14 to 2.7.8 #1300
- Adjusted cypress to match new button elements
- Override styles for header actions as they use the new ButtonVue now
- BUG: Focus already set during loading process
- BUG: Focus trap is preventing the sidebar to be usable Fix issues with focus trap on modal nextcloud-libraries/nextcloud-vue#3020
- BUG: Focus trap is preventing the editor modals/menus to be usable
- Modal close is broken Fix Modal closing nextcloud-libraries/nextcloud-vue#3066 6.0.0-beta.4 nextcloud-libraries/nextcloud-vue#3092
- Fixes Add role="dialog" to improve accessibility #1289
feef129
to
91e5084
Compare
/compile amend / |
91e5084
to
d7ab8b5
Compare
97eb4ef
to
728881a
Compare
a2fb110
to
7e61528
Compare
@@ -900,6 +906,17 @@ export default { | |||
} | |||
} | |||
|
|||
&.theme--dark::v-deep .button-vue--vue-tertiary { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to enforce the theme used more beautifully with css variables now
As well with the data-theme attribute @juliushaertl
dfeedb6
to
0fb6d8c
Compare
@juliushaertl do you know how we can adjust that here? Also the editor popups/modals |
0fb6d8c
to
32698b1
Compare
Popovers like the ones from actions should be handled separately anyways by their own focus trap. Maybe you can share what the SfxModal-Wrapper does and how it gets initialised? |
Is there any way you could trigger a callback on showing/hiding those? I assume they are handled fully by the image editor library :/ |
Yep! |
32698b1
to
7a121e5
Compare
Fixed, not super fond, but works™ |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
7a121e5
to
61ee392
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
61ee392
to
9320acb
Compare