Fix password confirmation #1061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…whenever the user ID is obtained from the user backend Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…TION to true to prevent password validation Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
8 tasks
|
Just for confirmation, |
|
@waza-ari It is internal to the server. Nothing that the users or the admins should be aware of. |
34615e6 to
b0b5588
Compare
run cs:fix Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
b0b5588 to
f1f7992
Compare
blizzz
reviewed
Feb 20, 2025
| // prevent password confirmation | ||
| if (defined(IToken::class . '::SCOPE_SKIP_PASSWORD_VALIDATION')) { | ||
| $token = $this->authTokenProvider->getToken($this->session->getId()); | ||
| $token->setScope([IToken::SCOPE_SKIP_PASSWORD_VALIDATION => true]); |
There was a problem hiding this comment.
IIRC, if another scope was set, it needs to be taken over, this would replace it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs nextcloud/server#43612
last-password-confirmin the session everytime the user ID is obtained inOCA\UserOIDC\User\Backend::getCurrentUserId()OCP\Authentication\Token\ITokenIToken::SCOPE_SKIP_PASSWORD_VALIDATIONis defined (it was introduced in 30)Maybe 1. is not necessary. Wdyt?