Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProvisioningService): Handle InvalidArgumentException when updating account #1058

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 17, 2025

The updateAccount is documented as throwing an InvalidArgumentException if one of the changed properties is invalid. We should then simply reset that value.

…ting account

The `updateAccount` is documented as throwing an
`InvalidArgumentException` if one of the changed properties is invalid.
We should then simply reset that value.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review labels Feb 17, 2025
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with an invalid phone number, works fine!

@julien-nc julien-nc merged commit 314b32d into main Feb 17, 2025
51 checks passed
@julien-nc julien-nc deleted the fix/handle-invalid-argument-update-account branch February 17, 2025 10:17
@julien-nc julien-nc mentioned this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: login fails with user_oidc if phone number attribute is invalid
3 participants