bump min nc version to 25, fix all psalm errors, add psalm check, add…

… php-cs:check run php-cs:fix

remove 'output' command option that is already set in OC\Core\Command\base

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

.github/workflows/integration.yml

@@ -22,9 +22,6 @@ jobs:
         databases: ['sqlite', 'mysql', 'pgsql']
         server-versions: ['master']
         include:
-            - php-versions: 8.1
-              databases: mysql
-              server-versions: stable24
             - php-versions: 8.1
               databases: mysql
               server-versions: stable25

.github/workflows/phpunit.yml

@@ -21,7 +21,7 @@ jobs:
       matrix:
         php-versions: ['7.4', '8.0', '8.1']
         databases: ['mysql']
-        server-versions: ['stable24', 'stable25', 'stable26', 'stable27', 'stable28', 'master']
+        server-versions: ['stable25', 'stable26', 'stable27', 'stable28', 'master']
         exclude:
           - php-versions: 7.4
             server-versions: master

.github/workflows/psalm.yml

@@ -0,0 +1,57 @@
+# This workflow is provided via the organization template repository
+#
+# https://github.com/nextcloud/.github
+# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
+
+name: Psalm static analysis
+
+on:
+  pull_request:
+    paths:
+      - .github/workflows/psalm.yml
+      - appinfo/**
+      - composer.*
+      - lib/**
+      - templates/**
+      - tests/**
+  push:
+    branches:
+      - main
+      - stable*
+      - test
+    paths:
+      - .github/workflows/psalm.yml
+      - appinfo/**
+      - composer.*
+      - lib/**
+      - templates/**
+      - tests/**
+
+concurrency:
+  group: psalm-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  static-analysis:
+    runs-on: ubuntu-latest
+
+    name: Psalm check
+    steps:
+      - name: Checkout
+        uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2
+
+      - name: Set up php
+        uses: shivammathur/setup-php@c5fc0d8281aba02c7fda07d3a70cc5371548067d # v2
+        with:
+          php-version: 8.2
+          coverage: none
+          ini-file: development
+          extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite, gd, zip
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Install dependencies
+        run: composer i
+
+      - name: Run coding standards check
+        run: composer run psalm

appinfo/info.xml

@@ -19,7 +19,7 @@
 	<bugs>https://github.com/nextcloud/user_oidc/issues</bugs>
 	<repository>https://github.com/nextcloud/user_oidc</repository>
 	<dependencies>
-		<nextcloud min-version="24" max-version="29"/>
+		<nextcloud min-version="25" max-version="29"/>
 	</dependencies>
 	<settings>
 		<admin>OCA\UserOIDC\Settings\AdminSettings</admin>

composer.json

@@ -9,14 +9,15 @@
       "bamarni/composer-bin-plugin": true
     },
 	"platform": {
-      "php": "7.4"
+      "php": "8.0"
     }
   },
   "scripts": {
     "cs:fix": "php-cs-fixer fix",
     "cs:check": "php-cs-fixer fix --dry-run --diff",
     "lint": "find . -name \\*.php ! -path './vendor/*' ! -path './vendor-bin/*' ! -path './lib/Vendor/*' -exec php -l \"{}\" \\;",
     "test:unit": "phpunit -c tests/phpunit.xml",
+    "psalm": "psalm.phar --no-cache",
     "post-install-cmd": [
       "@composer bin all install --ansi",
       "\"vendor/bin/mozart\" compose",
@@ -36,7 +37,9 @@
   "require-dev": {
     "nextcloud/coding-standard": "^1.0.0",
     "symfony/event-dispatcher": "^4",
-    "phpunit/phpunit": "^9.5"
+    "phpunit/phpunit": "^9.5",
+    "nextcloud/ocp": "dev-stable25",
+    "psalm/phar": "^5.20"
   },
   "extra": {
     "mozart": {