Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exceptions instead of booleans #103

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Use exceptions instead of booleans #103

merged 1 commit into from
Apr 14, 2022

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Apr 13, 2022 •
edited
Loading

Adjust code according to the updated interfaces

@PVince81
Use exceptions instead of booleans
f7b7397 
Adjust code according to the updated interfaces

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 added the 3. to review Waiting for reviews label Apr 13, 2022
@PVince81 PVince81 added this to the 0.1 milestone Apr 13, 2022
@PVince81 PVince81 requested review from Pytal and come-nc April 13, 2022 14:54
@PVince81 PVince81 self-assigned this Apr 13, 2022
@PVince81 PVince81 mentioned this pull request Apr 13, 2022
Merged
@PVince81
Copy link
Member Author

tested with nextcloud/server#31945 and both occ export and import worked.

@PVince81
Copy link
Member Author

PVince81 commented Apr 13, 2022 •
edited
Loading

static failure is because the server PR is not merged yet

@PVince81
Copy link
Member Author

master is merged, I've restarted the workflows

@PVince81
Copy link
Member Author

boo, still failing. no idea... might need to retry the workflows later

@Pytal
Copy link
Member

Pytal commented Apr 13, 2022

boo, still failing. no idea... might need to retry the workflows later

Which one?

The Static analysis one would need to wait for next bump of christophwurst/nextcloud https://github.com/ChristophWurst/nextcloud_composer/commits/master which we can just ignore for now if urgent as server PR was merged

@Pytal Pytal mentioned this pull request Apr 13, 2022
Closed
@Pytal Pytal linked an issue Apr 13, 2022 that may be closed by this pull request
Improve error information when file operation fail #85
Closed
@Pytal Pytal mentioned this pull request Apr 14, 2022
Merged
3 tasks
@PVince81 PVince81 merged commit 5ad9f18 into main Apr 14, 2022
@PVince81 PVince81 deleted the fix/user_migration-use-exceptions branch April 14, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@PVince81 PVince81

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Improve error information when file operation fail
2 participants
@PVince81 @Pytal