Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "disable upgrades to 26 on 32-bit" #464

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Revert "disable upgrades to 26 on 32-bit" #464

merged 2 commits into from
Feb 9, 2023

Conversation

come-nc
Copy link
Collaborator

@come-nc come-nc commented Feb 7, 2023

Reverts #446

@come-nc come-nc self-assigned this Feb 7, 2023
@come-nc come-nc requested a review from szaimen February 7, 2023 13:45
@come-nc come-nc added this to the Nextcloud 26 milestone Feb 7, 2023
@come-nc come-nc mentioned this pull request Feb 7, 2023
Closed
20 tasks
@come-nc
Copy link
Collaborator Author

come-nc commented Feb 7, 2023

/backport to stable25

szaimen
szaimen reviewed Feb 7, 2023
View reviewed changes
index.php Outdated Show resolved Hide resolved
szaimen
szaimen requested changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also you deleted the updater.phar?

@come-nc
Copy link
Collaborator Author

come-nc commented Feb 8, 2023

also you deleted the updater.phar?

No?

@come-nc
Revert "disable upgrades to 26 on 32-bit"
64e2e4c 
This reverts commit d57a58e.
This reverts commit ddc200d.
This reverts commit 163f362.
This reverts commit 9cc0541.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Removed empty lines in index.php added by the revert
c23ee77 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
szaimen
szaimen approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@come-nc come-nc requested a review from blizzz February 8, 2023 12:31
@blizzz blizzz merged commit 744f04d into master Feb 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the revert/446 branch February 9, 2023 10:15
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 9, 2023
Merged
@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@come-nc come-nc

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @blizzz @szaimen