Merge pull request #556 from nextcloud/bugfix/noid/check-function-call

fix: Correctly check result of function
nextcloud · May 15, 2024 · 703f99d · 703f99d
2 parents c724e53 + e21395e
commit 703f99d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/index.php b/index.php
@@ -710,12 +710,12 @@ public function verifyIntegrity(): void {
 -----END CERTIFICATE-----
 EOF;
 
-		$validSignature = (bool)openssl_verify(
+		$validSignature = openssl_verify(
 			file_get_contents($this->getDownloadedFilePath()),
 			base64_decode($response['signature']),
 			$certificate,
 			OPENSSL_ALGO_SHA512
-		);
+		) === 1;
 
 		if ($validSignature === false) {
 			throw new \Exception('Signature of update is not valid');

diff --git a/lib/Updater.php b/lib/Updater.php
@@ -672,12 +672,12 @@ public function verifyIntegrity(): void {
 -----END CERTIFICATE-----
 EOF;
 
-		$validSignature = (bool)openssl_verify(
+		$validSignature = openssl_verify(
 			file_get_contents($this->getDownloadedFilePath()),
 			base64_decode($response['signature']),
 			$certificate,
 			OPENSSL_ALGO_SHA512
-		);
+		) === 1;
 
 		if ($validSignature === false) {
 			throw new \Exception('Signature of update is not valid');

diff --git a/updater.phar b/updater.phar