Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep layout on sync errors #6903

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Feb 14, 2025

See #6877

Ui changes

  • fix(ui): move document status to the bottom

๐Ÿ–ผ๏ธ Screenshots

๐Ÿš๏ธ before ๐Ÿก after
Sync error Bildschirmfoto vom 2025-02-14 12-56-16 grafik
Conflict view Bildschirmfoto vom 2025-02-14 00-00-36 Bildschirmfoto vom 2025-02-14 00-00-21
Notifications Bildschirmfoto vom 2025-02-14 13-19-12 Bildschirmfoto vom 2025-02-14 13-18-25

Other commits

  • fix(vite): allow hostnames used for hmr via docker-dev

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud requested a review from mejo- as a code owner February 14, 2025 11:11
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.87%. Comparing base (c801b12) to head (d9d2506).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor.vue 0.00% 2 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6903      +/-   ##
==========================================
+ Coverage   37.85%   37.87%   +0.02%     
==========================================
  Files         750      740      -10     
  Lines       42643    42625      -18     
  Branches     1273     1263      -10     
==========================================
+ Hits        16142    16146       +4     
+ Misses      25879    25867      -12     
+ Partials      622      612      -10     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud requested review from marcoambrosini and a team February 14, 2025 12:35
@max-nextcloud max-nextcloud self-assigned this Feb 14, 2025
@max-nextcloud max-nextcloud force-pushed the enh/keep-layout-on-sync-errors branch from af40cfd to d9d2506 Compare February 14, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ๐Ÿ‘€ In review
Development

Successfully merging this pull request may close these issues.

1 participant