-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): add tiptap-text-direction
extension to support RTL
#6874
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🙏🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures look related as now dir="ltr"
is include in some of the html output of the unit tests. I think you can just adjust the expectation to match the actual outcome - and we get a test for this extension for free.
Other than that and the linter fix this looks great. Thanks for looking into it!
Would be nice if we could backport it as I think it really fixes a UX bug for rtl and mixed language use.
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
7511bea
to
6c1bcf3
Compare
/backport to stable28 |
/backport to stable29 |
/backport to stable30 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6874 +/- ##
==========================================
+ Coverage 37.85% 37.99% +0.13%
==========================================
Files 750 735 -15
Lines 42637 42498 -139
Branches 1273 1258 -15
==========================================
+ Hits 16142 16146 +4
+ Misses 25873 25745 -128
+ Partials 622 607 -15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks sane, @max-nextcloud could you also have a quick look/approval before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good. Thanks for taking care of this.
🚀
Not sure what happened with the cypress tests. Restarted them. |
📝 Summary
Now it is possible to detect RTL writing style for languages, which requires RTL. Using https://github.com/amirhhashemi/tiptap-text-direction extension. This version works for:
🖼️ Screenshots
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)