Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Fix(plaintext): multiple linebreaks at end #6561

Closed
wants to merge 2 commits into from
Closed

[stable28] Fix(plaintext): multiple linebreaks at end #6561

wants to merge 2 commits into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 23, 2024

Backport of PR #6508

@backportbot backportbot bot added this to the Nextcloud 28.0.12 milestone Oct 23, 2024
@max-nextcloud max-nextcloud force-pushed the backport/6508/stable28 branch from 3d902ba to a236d86 Compare October 24, 2024 16:48
@Altahrim Altahrim mentioned this pull request Oct 30, 2024
Merged
2 tasks
@Altahrim Altahrim changed the title [stable28] [stable30] Fix(plaintext): multiple linebreaks at end [stable28] Fix(plaintext): multiple linebreaks at end Oct 30, 2024
@Altahrim
Copy link

CI sounds related

This was referenced Nov 5, 2024
Merged
Merged
@juliusknorr juliusknorr force-pushed the backport/6508/stable28 branch from a236d86 to 52d09b1 Compare November 7, 2024 18:18
@juliusknorr juliusknorr added the bug Something isn't working label Nov 18, 2024
@skjnldsv skjnldsv mentioned this pull request Nov 27, 2024
Merged
4 tasks
@blizzz blizzz mentioned this pull request Dec 5, 2024
Merged
@blizzz blizzz removed this from the Nextcloud 28.0.13 milestone Dec 5, 2024
juliusknorr
juliusknorr requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-nextcloud Also needs adjustments

@max-nextcloud
fix(plaintext): allow adding multiple empty lines at the end
0696c1d 
Pressing enter three times exits a CodeBlock element by default.
Disable this by setting `exitOnTripleEnter` to false in plaintext editor.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
test(plaintext) add regression test for newlines
9c0548a 
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
Copy link
Collaborator

I fixed the jest test. I think the cypress component test failure is unrelated.

@mejo-
Copy link
Member

mejo- commented Dec 10, 2024

Let's close this one as stable28 is EOL.

@mejo- mejo- closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr requested changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees

@max-nextcloud max-nextcloud

Labels
3. to review bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Altahrim @max-nextcloud @mejo- @juliusknorr @blizzz