Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/5524 link preview add button to delete links in preview mode #5575

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Feat/5524 link preview add button to delete links in preview mode #5575

merged 4 commits into from
Mar 28, 2024

Conversation

grnd-alt
Copy link
Member

📝 Summary

🖼️ Screenshots

image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

grnd-alt added 2 commits March 27, 2024 15:55
@grnd-alt
add Delete Button to link Previews
44d4866 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt
use correct function for value change
89e9953 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt grnd-alt linked an issue Mar 27, 2024 that may be closed by this pull request
Link Preview: Add button to delete links in preview mode #5524
Closed
@grnd-alt grnd-alt requested review from juliusknorr and mejo- March 28, 2024 07:06
juliusknorr
juliusknorr requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing big, looks good otherwise :)

src/components/Editor/PreviewOptions.vue Outdated Show resolved Hide resolved
src/nodes/ParagraphView.vue Outdated Show resolved Hide resolved
src/nodes/ParagraphView.vue Outdated Show resolved Hide resolved
src/nodes/Preview.vue Outdated Show resolved Hide resolved
@juliusknorr juliusknorr added enhancement New feature or request 2. developing labels Mar 28, 2024
@juliusknorr juliusknorr added this to the Nextcloud 29 milestone Mar 28, 2024
@grnd-alt
adapt to nextcloud code style
3be23e5 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt grnd-alt requested a review from juliusknorr March 28, 2024 11:18
@grnd-alt
add cypress test for PreviewOptions
986cc8c 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt grnd-alt force-pushed the feat/5524-link-preview-add-button-to-delete-links-in-preview-mode branch from ccdf396 to 986cc8c Compare March 28, 2024 11:22
juliusknorr
juliusknorr approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for also covering this with tests.

Mind to squash your commits into an atomic one?

@grnd-alt grnd-alt merged commit 49bb2f2 into main Mar 28, 2024
59 checks passed
@grnd-alt grnd-alt deleted the feat/5524-link-preview-add-button-to-delete-links-in-preview-mode branch March 28, 2024 13:09
@juliusknorr
Copy link
Member

/backport 49bb2f2 to stable29

backportbot bot pushed a commit that referenced this pull request Mar 28, 2024
@grnd-alt @backportbot
Feat/5524 link preview add button to delete links in preview mode (#5575
e31628e 
)

* add Delete Button to link Previews

* add cypress test for PreviewOptions

---------

Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@backportbot backportbot bot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

Assignees
No one assigned
Labels
2. developing enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Link Preview: Add button to delete links in preview mode
2 participants
@grnd-alt @juliusknorr