Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] fix(frontend): Improve paste handler for table cells #4471

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #4452

This replaces the broken approach from #3906.

* Only regard paste handler if pasting to a table cell (Fixes: #4443)
* Add all (marked) text nodes with newlines in between
* Only add a newline for non-text nodes to prevent newlines in between
  text with changing marks.

Signed-off-by: Jonas <jonas@freesources.org>
@backportbot-nextcloud backportbot-nextcloud bot added the bug Something isn't working label Jul 10, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26.0.4 milestone Jul 10, 2023
@mejo-
Copy link
Member

mejo- commented Jul 10, 2023

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@cypress
Copy link

cypress bot commented Jul 10, 2023

1 failed and 1 flaky tests on run #10918 ↗︎

1 144 1 0 Flakiness 1

Details:

[stable26] fix(frontend): Improve paste handler for table cells
Project: Text Commit: ac41549c5a
Status: Failed Duration: 07:31 💡
Started: Jul 10, 2023 11:02 AM Ended: Jul 10, 2023 11:10 AM
Failed  cypress/e2e/sync.spec.js • 1 failed test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  cypress/e2e/share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo- mejo- merged commit 7ff5828 into stable26 Jul 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the backport/4452/stable26 branch July 10, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants