Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] fix: split layout of conflict view #3959

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 17, 2023

  • ⚠️ This backport's changes differ from the original and might be incomplete

backport of #3951

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26 milestone Mar 17, 2023
@cypress
Copy link

cypress bot commented Mar 17, 2023

1 flaky tests on run #9182 ↗︎

0 140 1 0 Flakiness 1

Details:

[stable26] fix: split layout of conflict view
Project: Text Commit: 0c783165a9
Status: Passed Duration: 04:47 💡
Started: Mar 23, 2023 10:01 PM Ended: Mar 23, 2023 10:06 PM
Flakiness  cypress/e2e/sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@blizzz blizzz mentioned this pull request Mar 20, 2023
@mejo- mejo- modified the milestones: Nextcloud 26, Nextcloud 26.0.1 Mar 20, 2023
@juliusknorr juliusknorr added the bug Something isn't working label Mar 21, 2023
Give both versions 50% of the screen space and try to vertically align them.
This should make comparing the versions easier.

Fixes #3950.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@mejo- mejo- force-pushed the backport/3951/stable26 branch from c994728 to f396655 Compare March 23, 2023 21:54
@mejo-
Copy link
Member

mejo- commented Mar 23, 2023

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo- mejo- merged commit e46d416 into stable26 Mar 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the backport/3951/stable26 branch March 23, 2023 22:08
@skjnldsv skjnldsv mentioned this pull request Apr 13, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants