Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editable attachment #3117

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Fix editable attachment #3117

merged 3 commits into from
Oct 3, 2022

Conversation

vinicius73
Copy link
Member

Summary

Any text inside the editor was editable, even if this content is not related from the source.

This PR fix it in ImageView.vue

@vinicius73 vinicius73 added bug Something isn't working design Experience, interaction, interface, … 3. to review format: markdown feature: images labels Oct 3, 2022
@vinicius73 vinicius73 added this to the Nextcloud 26 milestone Oct 3, 2022
@vinicius73
Copy link
Member Author

Waiting for nextcloud/server#34396 to fix CI

@mejo-
Copy link
Member

mejo- commented Oct 3, 2022

/rebase

Vinicius Reis added 2 commits October 3, 2022 20:19
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the fix/noid/fix-editable-attachment branch from 0d91dc2 to 4751007 Compare October 3, 2022 20:19
@mejo-
Copy link
Member

mejo- commented Oct 3, 2022

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo-
Copy link
Member

mejo- commented Oct 3, 2022

/backport 787077b,4751007fcf1266007635aec715b12f5c7b90cab2 to stable25

@mejo- mejo- merged commit 382083a into master Oct 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/fix-editable-attachment branch October 3, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working design Experience, interaction, interface, … feature: images format: markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants