Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: solve escape key closing the editor issue #2906

Merged
merged 2 commits into from
Sep 22, 2022
Merged

fix: solve escape key closing the editor issue #2906

merged 2 commits into from
Sep 22, 2022

Conversation

luka-nextcloud
Copy link
Contributor

Signed-off-by: Luka Trovic luka@nextcloud.com

Summary

vinicius73
vinicius73 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@vinicius73 vinicius73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well while you are with editor in focus (typing/editing)

But when your focus move to a dropdown menu (title, callouts...) esc key stil closing the modal.

I guess we can solve it in another issue.

@juliusknorr juliusknorr self-requested a review September 22, 2022 09:14
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Sep 22, 2022
@juliusknorr
Copy link
Member

But when your focus move to a dropdown menu (title, callouts...) esc key stil closing the modal.

Popovers are actually part of the body and not within the modal, but we might to prevent the escape key event bubbling in the actions in general in @nextcloud/vue. There currently the keydown handler is registered globally.

@luka-nextcloud @juliusknorr
fix: solve escape key closing the editor issue
99d3462 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliusknorr juliusknorr force-pushed the bug/escape-behavior-on-editor branch from f51b08f to 99d3462 Compare September 22, 2022 09:23
@juliusknorr
Copy link
Member

/compile

@juliusknorr juliusknorr added this to the Nextcloud 25 milestone Sep 22, 2022
@nextcloud-command
Compile assets
55f2a8e 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@blizzz blizzz mentioned this pull request Sep 22, 2022
Merged
2 tasks
@juliusknorr juliusknorr merged commit 8882995 into master Sep 22, 2022
@juliusknorr juliusknorr deleted the bug/escape-behavior-on-editor branch September 22, 2022 10:24
@juliusknorr
Copy link
Member

/backport to stable25

@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinicius73 vinicius73 vinicius73 approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

Escape key should not close the editor
5 participants
@luka-nextcloud @juliusknorr @vinicius73 @blizzz @nextcloud-command