[stable23] fix: menu bubble size at the end of the line #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8683e0d to
dd3488c
Compare
Compute menu bubble position without translateX. The previous approach made the bubble shrink towards the end of the line. Signed-off-by: Max <max@nextcloud.com>
When selecting the right-most chars in a line the menu bubble was getting too small. Meassure the menu bubble when it is drawn but still hidden. Calculate its position based on the editor width and the meassured bubble width. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
dd3488c to
dc34d7f
Compare
juliusknorr
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When selecting the right-most chars in a line
the menu bubble was getting too small.
Measure the menu bubble when it is drawn but still hidden.
Calculate its position based on the editor width and the measured bubble width.