Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide menu and keep focus when using menubar popover items #1959

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

juliusknorr
Copy link
Member

When using any formatting action from the collapsed menubar, this change will make sure that the popover gets hidden and the focus stays within the document.

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Nov 22, 2021
@juliusknorr juliusknorr added this to the Nextcloud 24 milestone Nov 22, 2021
@juliusknorr
Copy link
Member Author

/backport to stable23

@juliusknorr
Copy link
Member Author

/backport to stable22

@julien-nc julien-nc self-requested a review November 26, 2021 12:24
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Works perfectly.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/mobile-menu-popover branch from 0a52a7b to 93e3a09 Compare November 26, 2021 14:53
@juliusknorr juliusknorr merged commit 5da5d63 into master Nov 26, 2021
@juliusknorr juliusknorr deleted the bugfix/noid/mobile-menu-popover branch November 26, 2021 15:17
@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants