Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to insert text after trailing codeblock #1771

Merged
merged 1 commit into from
Oct 6, 2021
Merged

allow to insert text after trailing codeblock #1771

merged 1 commit into from
Oct 6, 2021

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 16, 2021

Fix #109
Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added this to the Nextcloud 23 milestone Jul 16, 2021
@szaimen
Copy link
Contributor Author

szaimen commented Jul 16, 2021

/compile amend /

@szaimen
Copy link
Contributor Author

szaimen commented Jul 16, 2021 •
edited
Loading

@juliushaertl I am honest: I don't know if this is the way to solve the mentioned bug or not but that's what I understood from the mentioned ticket, though I am not able to compile the code because the compile bot doesn't work...
I need some helping hands here...

@szaimen szaimen added help wanted Extra attention is needed bug Something isn't working labels Jul 16, 2021
@juliusknorr
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the fix/109/insert-text-after-trailing-codeblock branch from 596fd7f to 314c926 Compare October 6, 2021 09:34
@juliusknorr
Copy link
Member

/compile amend /

juliusknorr
juliusknorr approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 🚀

@juliusknorr juliusknorr added 4. to release and removed help wanted Extra attention is needed 2. developing labels Oct 6, 2021
@szaimen @nextcloud-command
allow to insert text after trailing codeblock
fbbab0b 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/109/insert-text-after-trailing-codeblock branch from 314c926 to fbbab0b Compare October 6, 2021 09:38
@szaimen szaimen merged commit 9482d1c into master Oct 6, 2021
@szaimen szaimen deleted the fix/109/insert-text-after-trailing-codeblock branch October 6, 2021 11:21
@szaimen
Copy link
Contributor Author

szaimen commented Oct 6, 2021

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Oct 6, 2021

/backport to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Oct 6, 2021

/backport to stable20

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@juliusknorr juliusknorr mentioned this pull request Oct 28, 2021
Merged
@azul azul mentioned this pull request Jan 11, 2022
Merged
@azul azul added the backported successfully backported label Jan 11, 2022
@max-nextcloud max-nextcloud removed backport-request backported successfully backported labels Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
4. to release bug Something isn't working
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.

When a code block is the last thing in a document, then you can't insert text after it
4 participants
@szaimen @juliusknorr @azul @max-nextcloud