Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non md/txt files opening for external users only #651

Closed
wiswedel opened this issue Feb 3, 2020 · 7 comments
Closed

non md/txt files opening for external users only #651

wiswedel opened this issue Feb 3, 2020 · 7 comments
Assignees
Labels
1. to develop bug Something isn't working

Comments

@wiswedel
Copy link

wiswedel commented Feb 3, 2020

Describe the bug
Non md- or txt text-based files like .xml, .py or .json open for editing only for public sharees. Logged in users get stuck with an ever loading spinner.

To Reproduce
Steps to reproduce the behavior:

  1. As a logged in user, upload a .py or .xml or .json file to Nextcloud (these are the types I tested with, sure there are more)
  2. Share the file via public link with editing rights
  3. As a sharee, open the public link
  4. File opens for editing in Text
  5. As logged in user, open the same file

Expected behavior
File opens for editing in Text

Actual behavior

  • Text's top bar with sidebar- and closing controls shows
  • spinner in the screen's center spins forever

NC 18.0.0
Text 2.0.0

nothing in the logs

@wiswedel wiswedel added the bug Something isn't working label Feb 3, 2020
@SR4ven
Copy link

SR4ven commented Feb 16, 2020

Can confirm for NC 18.0.1, Test 2.0.0 with .c .bash .tex and .txt files.

@irBags
Copy link

irBags commented Mar 1, 2020

Can confirm for NC 18.0.1, any file containing text, that does not have a file extension of .md/.txt produces this behavior. Although, in my case it is producible regardless of public users or logged in users. Renaming the file with an .md/.txt extension resolves this issue - any party can then view the files contents.

@Pilzinsel64
Copy link

Pilzinsel64 commented Apr 2, 2020

This issue happens also to me with any browser on any desktop client and with tree nextcloud instances. The error started with v18.0.0. I created a new issue #745 with some detailes.

@wiswedel
Copy link
Author

wiswedel commented Apr 2, 2020

This issue happens also to me with any browser on any desktop client and with tree nextcloud instances. The error started with v18.0.0. I created a new issue #745 with some detailes.

Thanks for the details, but please don't open duplicates on purpose 🤔

@juliusknorr
Copy link
Member

I could reproduce, however I'm still not sure why this happens, so this needs some more investigation.

@Nevyn75
Copy link

Nevyn75 commented May 15, 2020

Hi.
Any news about this problem?
It's very useful to edit JSON directly online :-)

Thx!

@juliusknorr
Copy link
Member

A fix is in #775 but the backport is still pending #782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants