Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

403 on public share access #5368

Closed
KarlKeu00 opened this issue Feb 7, 2024 · 1 comment · Fixed by #5466
Closed

403 on public share access #5368

KarlKeu00 opened this issue Feb 7, 2024 · 1 comment · Fixed by #5466
Labels
1. to develop bug Something isn't working

Comments

@KarlKeu00
Copy link

KarlKeu00 commented Feb 7, 2024

Describe the bug
There is no way to deactivate the collaboration feature. When I share a folder and the end user is not authenticated, requests are still sent to /apps/text/public/session/push. These are rejected with 403 and lead to the user being blocked.

To Reproduce
Steps to reproduce the behavior:

  1. Publish a folder in read-only mode for public access.
  2. Open the link in an incognito window.
  3. Go to the browser console and search for "push" in the requests.

Expected behavior
No request to push or the option to deactivate the collaboration feature.

Screenshots
If applicable, add screenshots to help explain your problem.

Server details:

  • Nextcloud version: 27.1.6
  • PHP Version: Docker-Container (stable-apache)
  • Database: MariaDB 10.6

Client details:

  • OS: macOS
  • Browser: Brave
  • Browser version: v1.62.156
  • Device: desktop
@KarlKeu00 KarlKeu00 added the bug Something isn't working label Feb 7, 2024
@KarlKeu00
Copy link
Author

The following error also occurs:

TypeError: Cannot read properties of undefined (reading 'userId')
    at s.<anonymous> (Status.vue:1:857)
    at t._render (vue.runtime.esm.js:2700:28)
    at s.r (vue.runtime.esm.js:3891:27)
    at t.get (vue.runtime.esm.js:3462:33)
    at new t (vue.runtime.esm.js:3452:51)
    at t (vue.runtime.esm.js:3908:5)
    at li.$mount (vue.runtime.esm.js:8797:12)
    at init (vue.runtime.esm.js:4427:19)
    at vue.runtime.esm.js:6591:17
    at h (vue.runtime.esm.js:6545:13)

mejo- added a commit that referenced this issue Mar 12, 2024
This fixes read-only clients getting 403 responses on push requests that
only contain questions for updates.

Fixes: #5223
Fixes: #5366
Fixes: #5368

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 12, 2024
This fixes read-only clients getting 403 responses on push requests that
only contain questions for updates.

Fixes: #5223
Fixes: #5366
Fixes: #5368

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 12, 2024
This fixes read-only clients getting 403 responses on push requests that
only contain questions for updates.

Fixes: #5223
Fixes: #5366
Fixes: #5368

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 12, 2024
This fixes read-only clients getting 403 responses on push requests that
only contain questions for updates.

Fixes: #5223
Fixes: #5366
Fixes: #5368

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- closed this as completed in a43d77c Mar 12, 2024
backportbot bot pushed a commit that referenced this issue Mar 13, 2024
This fixes read-only clients getting 403 responses on push requests that
only contain questions for updates.

Fixes: #5223
Fixes: #5366
Fixes: #5368

Signed-off-by: Jonas <jonas@freesources.org>
backportbot bot pushed a commit that referenced this issue Mar 13, 2024
This fixes read-only clients getting 403 responses on push requests that
only contain questions for updates.

Fixes: #5223
Fixes: #5366
Fixes: #5368

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 13, 2024
This fixes read-only clients getting 403 responses on push requests that
only contain questions for updates.

Fixes: #5223
Fixes: #5366
Fixes: #5368

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants