Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User mention bubble broken in RichTextReader for users with space in username #4157

Closed
mejo- opened this issue May 8, 2023 · 0 comments · Fixed by #4588
Closed

User mention bubble broken in RichTextReader for users with space in username #4157

mejo- opened this issue May 8, 2023 · 0 comments · Fixed by #4588
Assignees
@mejo-
Labels
1. to develop bug Something isn't working high

Comments

@mejo-
Copy link
Member

mejo- commented May 8, 2023

Describe the bug
When usernames contain a whitespace,rendering of their user mention bubbles is broken in RichTextReader:

Screenshot
2023-05-08T15:34:06,913904465+01:00

To Reproduce
Steps to reproduce the behavior:

  1. Add a user with a whitespace in username to the Nextcloud instance
  2. In Collectives, mention this user in a page
  3. Switch to View mode, see the mention bubble is broken
@mejo- mejo- added bug Something isn't working 1. to develop high labels May 8, 2023
@mejo- mejo- added this to the Nextcloud 26.0.2 milestone May 8, 2023
@juliusknorr juliusknorr removed this from the Nextcloud 26.0.4 milestone Jun 29, 2023
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jul 11, 2023
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Jul 11, 2023
mejo- added a commit that referenced this issue Jul 27, 2023
@mejo-
fix(mentions): encode user id in mentions URLs
814ed3e 
Whitespaces in the URL of mentions break markdown parsing, which leads
to unrendered mentions for users with a whitespace in their userId.

Fixes: #4157

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- self-assigned this Jul 27, 2023
@mejo- mejo- moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Jul 27, 2023
@mejo- mejo- moved this from ☑️ Done to 🏗️ In progress in 📝 Office team Jul 27, 2023
@mejo- mejo- mentioned this issue Jul 27, 2023
Merged
5 tasks
mejo- added a commit that referenced this issue Jul 27, 2023
@mejo-
fix(mentions): encode user id in mentions URLs
63b05d2 
Whitespaces in the URL of mentions break markdown parsing, which leads
to unrendered mentions for users with a whitespace in their userId.

Fixes: #4157

Signed-off-by: Jonas <jonas@freesources.org>
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Jul 27, 2023
backportbot-nextcloud bot pushed a commit that referenced this issue Jul 27, 2023
@mejo- @backportbot-nextcloud
fix(mentions): encode user id in mentions URLs
f7d5e20 
Whitespaces in the URL of mentions break markdown parsing, which leads
to unrendered mentions for users with a whitespace in their userId.

Fixes: #4157

Signed-off-by: Jonas <jonas@freesources.org>
backportbot-nextcloud bot pushed a commit that referenced this issue Jul 27, 2023
@mejo- @backportbot-nextcloud
fix(mentions): encode user id in mentions URLs
3a5bb56 
Whitespaces in the URL of mentions break markdown parsing, which leads
to unrendered mentions for users with a whitespace in their userId.

Fixes: #4157

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejo- mejo-

Labels
1. to develop bug Something isn't working high
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mentions): encode user id in mentions URLs nextcloud/text
4 participants
@blizzz @juliusknorr @mejo- @max-nextcloud