Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new features to RichTextReader #2919

Closed
4 of 5 tasks
mejo- opened this issue Sep 14, 2022 · 5 comments · Fixed by #2970 or #3909
Closed
4 of 5 tasks

Add new features to RichTextReader #2919

mejo- opened this issue Sep 14, 2022 · 5 comments · Fixed by #2970 or #3909
Assignees
@mejo-
Labels
bug Something isn't working high
Milestone
Nextcloud 26

Comments

@mejo-
Copy link
Member

mejo- commented Sep 14, 2022 •
edited
Loading

Describe the bug
We need to add the new Text features to RichTextReader in order to use them in read-only mode (e.g. in Collectives):
@mejo- mejo- added the bug Something isn't working label Sep 14, 2022
@mejo- mejo- added this to the Nextcloud 25 milestone Sep 14, 2022
@juliusknorr
Copy link
Member

Good catch, is there any way we can unify the implementation so that future features would be implemented right away?

@mejo- mejo- mentioned this issue Sep 20, 2022
Merged
@mejo-
Copy link
Member Author

mejo- commented Sep 20, 2022

For now, the way to go is to implement them in RichText.js instead of EditorFactory.js. That way, they will be part of both RichTextReader.vue and Editor.vue. If they contain features that are only needed for the Editor though, we need to make sure that these parts are only loaded in EditorFactory.js and not in RichText.js (e.g. see EditableTable.js vs. Table.js).

I'm sure there's smarter solutions to this 😊

@mejo-
Copy link
Member Author

mejo- commented Sep 20, 2022

File attachments are rendered as images that were failed to load in RichTextReader.vue at the moment. The reason is that we don't pass the session as a property to AttachmentResolver in Collectives.

Images are still loaded because we have a fallback mechanism for them (they're requested via the DAV url if session is unset).

Maybe something to discuss next week @max-nextcloud @vinicius73 and @eneiluj.

@mejo- mejo- reopened this Sep 20, 2022
@vinicius73 vinicius73 mentioned this issue Sep 27, 2022
Merged
@mejo- mejo- added the high label Oct 10, 2022
@juliusknorr juliusknorr moved this to 📄 To do (~10 entries) in 📝 Office team Oct 17, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Oct 19, 2022
@mejo- mejo- moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Oct 26, 2022
@mejo- mejo- self-assigned this Oct 26, 2022
mejo- added a commit that referenced this issue Nov 1, 2022
@mejo-
Emit update when setting new editor content in BaseReader
e2f4143 
This is required for updateContent event listeners to run, e.g. to
update heading attributes.

Related: #2919

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this issue Nov 1, 2022
Merged
@mejo-
Copy link
Member Author

mejo- commented Nov 1, 2022

Heading anchor attributes will be fixed by #3345.

@juliusknorr
Copy link
Member

Added #2977 to the list

@juliusknorr juliusknorr mentioned this issue Nov 8, 2022
Closed
mejo- added a commit that referenced this issue Nov 21, 2022
@mejo-
Allow to change outline state from outside WrapperComponent
2bf1b53 
* Emit `outline-toggled` event when outline got toggled from Text
* Allow to pass property `showOutlineOutside` for changing outline state
  from parent component.

This is required to support toggeling the outline from inside
Collectives.

Related: #2919

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this issue Nov 21, 2022
Merged
3 tasks
mejo- added a commit that referenced this issue Nov 21, 2022
@mejo-
Allow to change outline state from outside WrapperComponent
76c4614 
* Emit `outline-toggled` event when outline got toggled from Text
* Allow to pass property `showOutlineOutside` for changing outline state
  from parent component.

This is required to support toggeling the outline from inside
Collectives.

Related: #2919

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Nov 22, 2022
@mejo-
Allow to change outline state from outside WrapperComponent
a9f4db5 
* Emit `outline-toggled` event when outline got toggled from Text
* Allow to pass property `showOutlineOutside` for changing outline state
  from parent component.

This is required to support toggeling the outline from inside
Collectives.

Related: #2919

Signed-off-by: Jonas <jonas@freesources.org>
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 22, 2022
@mejo- @backportbot-nextcloud
Allow to change outline state from outside WrapperComponent
4033feb 
* Emit `outline-toggled` event when outline got toggled from Text
* Allow to pass property `showOutlineOutside` for changing outline state
  from parent component.

This is required to support toggeling the outline from inside
Collectives.

Related: #2919

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Dec 20, 2022
@mejo-
Emit update when setting new editor content in BaseReader
5aed459 
This is required for updateContent event listeners to run, e.g. to
update heading attributes.

Related: #2919

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this issue Jan 3, 2023
Closed
mejo- added a commit that referenced this issue Mar 7, 2023
@mejo-
Get mimeIconUrl for media attachments without a session
60f12a5 
In order to have non-image attachments rendered in editors without
a session, `AttachmentResolver.resolve()` should return a candidate with
the mimeType icon as url as last resort - because all endpoints from
Text `AttachmentController` require a session.

This fixes rendering of non-image attachments in RichTextReader.

Fixes: #2919

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this issue Mar 7, 2023
Merged
4 tasks
mejo- added a commit that referenced this issue Mar 7, 2023
@mejo-
Get mimeIconUrl for media attachments without a session
0f6805c 
In order to have non-image attachments rendered in editors without
a session, `AttachmentResolver.resolve()` should return a candidate with
the mimeType icon as url as last resort - because all endpoints from
Text `AttachmentController` require a session.

This fixes rendering of non-image attachments in RichTextReader.

Fixes: #2919

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 15, 2023
@mejo-
Get mimeIconUrl for media attachments without a session
d124e5b 
In order to have non-image attachments rendered in editors without
a session, `AttachmentResolver.resolve()` should return a candidate with
the mimeType icon as url as last resort - because all endpoints from
Text `AttachmentController` require a session.

This fixes rendering of non-image attachments in RichTextReader.

Fixes: #2919

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 15, 2023
@mejo-
Get mimeIconUrl for media attachments without a session
bee70d2 
In order to have non-image attachments rendered in editors without
a session, `AttachmentResolver.resolve()` should return a candidate with
the mimeType icon as url as last resort - because all endpoints from
Text `AttachmentController` require a session.

This fixes rendering of non-image attachments in RichTextReader.

Fixes: #2919

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 16, 2023
@mejo-
Get mimeIconUrl for media attachments without a session
0b0d268 
In order to have non-image attachments rendered in editors without
a session, `AttachmentResolver.resolve()` should return a candidate with
the mimeType icon as url as last resort - because all endpoints from
Text `AttachmentController` require a session.

This fixes rendering of non-image attachments in RichTextReader.

Fixes: #2919

Signed-off-by: Jonas <jonas@freesources.org>
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Mar 16, 2023
backportbot-nextcloud bot pushed a commit that referenced this issue Mar 16, 2023
@mejo- @backportbot-nextcloud
Get mimeIconUrl for media attachments without a session
b611de7 
In order to have non-image attachments rendered in editors without
a session, `AttachmentResolver.resolve()` should return a candidate with
the mimeType icon as url as last resort - because all endpoints from
Text `AttachmentController` require a session.

This fixes rendering of non-image attachments in RichTextReader.

Fixes: #2919

Signed-off-by: Jonas <jonas@freesources.org>
@niklas-englert niklas-englert mentioned this issue Mar 22, 2023
Closed
mejo- added a commit that referenced this issue Mar 23, 2023
@mejo-
Get mimeIconUrl for media attachments without a session
f9d5d28 
In order to have non-image attachments rendered in editors without
a session, `AttachmentResolver.resolve()` should return a candidate with
the mimeType icon as url as last resort - because all endpoints from
Text `AttachmentController` require a session.

This fixes rendering of non-image attachments in RichTextReader.

Fixes: #2919

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 23, 2023
@mejo-
Get mimeIconUrl for media attachments without a session
8840265 
In order to have non-image attachments rendered in editors without
a session, `AttachmentResolver.resolve()` should return a candidate with
the mimeType icon as url as last resort - because all endpoints from
Text `AttachmentController` require a session.

This fixes rendering of non-image attachments in RichTextReader.

Fixes: #2919

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejo- mejo-

Labels
bug Something isn't working high
Projects
📝 Office team
Archived in project
Milestone
Nextcloud 26
3 participants
@blizzz @juliusknorr @mejo-