-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue pasting certain tables #2708
Comments
@max-nextcloud Any idea on why that could happen? |
I don't get it. This looks pretty much just like our table definition. It looks like the first within the first are not getting parsed as tableHeader. We have this rule in there:
I'm pretty sure that should match. Could you try and query for that selector in the html doc? |
We should also have a rule for that:
The second query you tried looks more flexible and also very good. The first-child might be a |
I can still reproduce this. I created a test that loads a table with that structure and that works just fine. Maybe it's about pasting the structure. |
Fixes #2708. Try to read the first table row as headings. Pasting works via `insertContent` while opening uses `setContent`. They use the schema in different ways. So we also need to make sure to test both for some corner cases. `setContent` is fairly flexible in turning the input into a valid document structure. `insertContent` however fails to resolve structures that would require picking lower priority parent elements. Note: Some tests in src/tests/nodes/Table.spec.js fail when using `insertContent` instead of `setContent`. Pasting the correponding html table is fixed never the less. Signed-off-by: Max <max@nextcloud.com>
Fixes #2708. Try to read the first table row as headings. Pasting works via `insertContent` while opening uses `setContent`. They use the schema in different ways. So we also need to make sure to test both for some corner cases. `setContent` is fairly flexible in turning the input into a valid document structure. `insertContent` however fails to resolve structures that would require picking lower priority parent elements. Note: Some tests in src/tests/nodes/Table.spec.js fail when using `insertContent` instead of `setContent`. Pasting the correponding html table is fixed never the less. Signed-off-by: Max <max@nextcloud.com>
Fixes #2708. Try to read the first table row as headings. Pasting works via `insertContent` while opening uses `setContent`. They use the schema in different ways. So we also need to make sure to test both for some corner cases. `setContent` is fairly flexible in turning the input into a valid document structure. `insertContent` however fails to resolve structures that would require picking lower priority parent elements. Note: Some tests in src/tests/nodes/Table.spec.js fail when using `insertContent` instead of `setContent`. Pasting the correponding html table is fixed never the less. Signed-off-by: Max <max@nextcloud.com>
Fixes #2708. Try to read the first table row as headings. Pasting works via `insertContent` while opening uses `setContent`. They use the schema in different ways. So we also need to make sure to test both for some corner cases. `setContent` is fairly flexible in turning the input into a valid document structure. `insertContent` however fails to resolve structures that would require picking lower priority parent elements. Note: Some tests in src/tests/nodes/Table.spec.js fail when using `insertContent` instead of `setContent`. Pasting the correponding html table is fixed never the less. Signed-off-by: Max <max@nextcloud.com>
Fixes #2708. Try to read the first table row as headings. Pasting works via `insertContent` while opening uses `setContent`. They use the schema in different ways. So we also need to make sure to test both for some corner cases. `setContent` is fairly flexible in turning the input into a valid document structure. `insertContent` however fails to resolve structures that would require picking lower priority parent elements. Note: Some tests in src/tests/nodes/Table.spec.js fail when using `insertContent` instead of `setContent`. Pasting the correponding html table is fixed never the less. Signed-off-by: Max <max@nextcloud.com>
Fixes #2708. Try to read the first table row as headings. Pasting works via `insertContent` while opening uses `setContent`. They use the schema in different ways. So we also need to make sure to test both for some corner cases. `setContent` is fairly flexible in turning the input into a valid document structure. `insertContent` however fails to resolve structures that would require picking lower priority parent elements. Note: Some tests in src/tests/nodes/Table.spec.js fail when using `insertContent` instead of `setContent`. Pasting the correponding html table is fixed never the less. Signed-off-by: Max <max@nextcloud.com> Signed-off-by: Jonas <jonas@freesources.org>
Fixes #2708. Try to read the first table row as headings. Pasting works via `insertContent` while opening uses `setContent`. They use the schema in different ways. So we also need to make sure to test both for some corner cases. `setContent` is fairly flexible in turning the input into a valid document structure. `insertContent` however fails to resolve structures that would require picking lower priority parent elements. Note: Some tests in src/tests/nodes/Table.spec.js fail when using `insertContent` instead of `setContent`. Pasting the correponding html table is fixed never the less. Signed-off-by: Max <max@nextcloud.com> Signed-off-by: Jonas <jonas@freesources.org>
Fixes #2708. Try to read the first table row as headings. Pasting works via `insertContent` while opening uses `setContent`. They use the schema in different ways. So we also need to make sure to test both for some corner cases. `setContent` is fairly flexible in turning the input into a valid document structure. `insertContent` however fails to resolve structures that would require picking lower priority parent elements. Note: Some tests in src/tests/nodes/Table.spec.js fail when using `insertContent` instead of `setContent`. Pasting the correponding html table is fixed never the less. Signed-off-by: Max <max@nextcloud.com>
The text was updated successfully, but these errors were encountered: