Skip to content

Commit

Permalink
Merge pull request #5304 from nextcloud/backport/5302/stable28
Browse files Browse the repository at this point in the history
[stable28] fix(mention): use new url schema
  • Loading branch information
juliusknorr authored Jan 26, 2024
2 parents 21a2a31 + e70b554 commit dff227c
Show file tree
Hide file tree
Showing 16 changed files with 27 additions and 23 deletions.
3 changes: 3 additions & 0 deletions cypress/e2e/nodes/Mentions.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,11 @@ describe('Test mentioning users', () => {

return cy.wait(`@${autocompleteReauestAlias}`)
.then(() => {
cy.intercept({ method: 'PUT', url: '**/mention' }).as('putMention')
cy.get('.tippy-box .suggestion-list').contains(mention).click()
cy.get('span.mention').contains(mention).should('be.visible')
cy.wait('@putMention')
.its('response.statusCode').should('eq', 200)
})
})

Expand Down
4 changes: 2 additions & 2 deletions js/editor.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/editor.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/text-editors.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/text-editors.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/text-files.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/text-files.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/text-init.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/text-init.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/text-public.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/text-public.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/text-text.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/text-text.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/text-viewer.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/text-viewer.js.map

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions src/components/Suggestion/Mention/suggestions.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ import createSuggestions from '../suggestions.js'
const USERS_LIST_ENDPOINT_URL = generateUrl('apps/text/api/v1/users')

const emitMention = ({ session, props }) => {
axios.put(generateUrl('apps/text/session/mention'), {
documentId: session.documentId,
const documentId = session.documentId
axios.put(generateUrl(`apps/text/session/${documentId}/mention`), {
documentId,
sessionId: session.id,
sessionToken: session.token,
mention: props.id,
Expand Down

0 comments on commit dff227c

Please sign in to comment.