Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-21.0] fix(lint): Use plurals string instead of simple string #4727

Merged
merged 2 commits into from
Feb 16, 2025
Merged

[stable-21.0] fix(lint): Use plurals string instead of simple string #4727

merged 2 commits into from
Feb 16, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 16, 2025 •
edited by AndyScherzinger
Loading

Backport of #4725

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@AndyScherzinger @backportbot
fix(lint): Use plurals string instead of simple string
f02cd80 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@backportbot backportbot bot added 3. to review Waiting for reviews technical debt Technical issue labels Feb 16, 2025
@backportbot backportbot bot added this to the 21.0.0 milestone Feb 16, 2025
@AndyScherzinger AndyScherzinger force-pushed the backport/4725/stable-21.0 branch from 878f686 to f02cd80 Compare February 16, 2025 15:43
@AndyScherzinger AndyScherzinger marked this pull request as ready for review February 16, 2025 15:46
@github-actions GitHub Actions
Copy link
Contributor

Lint

Typestable-21.0PR
Warnings104105
Errors369

SpotBugs

CategoryBaseNew
Bad practice06
Correctness0222
Dodgy code071
Internationalization03
Malicious code vulnerability03
Performance04
Security01
Total0310

Lint increased!

SpotBugs increased!

@AndyScherzinger
ci: pin analysis on stable branch
b13a320 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the backport/4725/stable-21.0 branch from 07fec41 to b13a320 Compare February 16, 2025 16:00
@AndyScherzinger AndyScherzinger merged commit 4e29550 into stable-21.0 Feb 16, 2025
11 of 12 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/4725/stable-21.0 branch February 16, 2025 16:00
@github-actions GitHub Actions
Copy link
Contributor

Lint

Typestable-21.0PR
Warnings105105
Errors369

SpotBugs

CategoryBaseNew
Bad practice06
Correctness0222
Dodgy code071
Internationalization03
Malicious code vulnerability03
Performance04
Security01
Total0310

SpotBugs increased!

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4727-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

@AndyScherzinger AndyScherzinger

Labels
3. to review Waiting for reviews technical debt Technical issue
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@AndyScherzinger