Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable less/more specific errors #9970

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Enable less/more specific errors #9970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions psalm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
</ignoreFiles>
</projectFiles>
<issueHandlers>
<LessSpecificReturnStatement errorLevel="error"/>
<LessSpecificReturnType errorLevel="error"/>
<LessSpecificImplementedReturnType errorLevel="error"/>
<MoreSpecificReturnType errorLevel="error"/>
<UndefinedClass>
<errorLevel type="suppress">
<referencedClass name="Doctrine\DBAL\Exception" />
Expand Down
12 changes: 9 additions & 3 deletions tests/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.11.0@c9b192ab8400fdaf04b2b13d110575adc879aa90">
<files psalm-version="5.13.1@086b94371304750d1c673315321a55d15fc59015">
<file src="lib/AppInfo/Application.php">
<UndefinedClass>
<code>BeforeTemplateRenderedEvent</code>
Expand Down Expand Up @@ -198,7 +198,7 @@
</file>
<file src="lib/Migration/Version2001Date20170707115443.php">
<InvalidArrayAccess>
<code>$return['num_rooms']</code>
<code><![CDATA[$return['num_rooms']]]></code>
</InvalidArrayAccess>
</file>
<file src="lib/Notification/Notifier.php">
Expand All @@ -225,14 +225,20 @@
</UndefinedClass>
</file>
<file src="lib/Service/RecordingService.php">
<LessSpecificReturnStatement>
<code>$recordingFolder</code>
</LessSpecificReturnStatement>
<MoreSpecificReturnType>
<code>Folder</code>
</MoreSpecificReturnType>
<UndefinedClass>
<code>NoUserException</code>
<code>NoUserException</code>
</UndefinedClass>
</file>
<file src="lib/Share/Listener.php">
<InvalidArgument>
<code>[self::class, 'listenPreShare']</code>
<code><![CDATA[[self::class, 'listenPreShare']]]></code>
</InvalidArgument>
<UndefinedClass>
<code><![CDATA[$event->getView()]]></code>
Expand Down