-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): prevent typing indicator overlay #9826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and thanks for contributing to us!
It's a nice work, but i have found a couple of places, which could be improved. Please see the comments below:
And in addition to that (saw from your screenshot): could the position of "Scroll to bottom" button be corrected, like on the left screenshot?
If we hardcode the position of the button, it may happen that button will overlap the text. Wouldn't it be better if we hid the button using opacity? This way the scrolling will not jump and the button position will be adaptive. But we will need to remove the extra space under the text... |
That's the side effect of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! I have some thoughts on how to make scroll-to-bottom button work, but it requires a lot of code movements. How about we squash your commits into one and merge, and work on button in separate PR?
Signed-off-by: Dmtriy Orlov <d.orlov777@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Position of "Scroll to bottom" goes to follow-up, as it needs more than a style refactoring.
The indicator itself is looking great now, thanks again!
/backport to stable27 |
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required