Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uploading video backgrounds from Files #9786

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix uploading video backgrounds from Files #9786

merged 1 commit into from
Jun 16, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Visual check
  • Code review

🏁 Checklist

@Antreesy
skip only client.createDirectory if exists already
100afe6 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💜 Next Major (28) milestone Jun 15, 2023
@Antreesy Antreesy self-assigned this Jun 15, 2023
@Antreesy
Copy link
Contributor Author

/backport to stable27

ChristophWurst
ChristophWurst approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane

marcoambrosini
marcoambrosini approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works :)

@marcoambrosini marcoambrosini merged commit 502c4b3 into master Jun 16, 2023
@marcoambrosini marcoambrosini deleted the fix/9783/dont-skip-file-picker branch June 16, 2023 06:12
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Can't pick video background from files: TypeError: ch is undefined
3 participants
@Antreesy @ChristophWurst @marcoambrosini