Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load new participants by actor when the session does not exist yet #4682

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Load new participants by actor when the session does not exist yet #4682

merged 1 commit into from
Nov 27, 2020

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen
Load new participants by actor when the session does not exist yet
15fc38b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the 💚 Next Major (21) milestone Nov 27, 2020
fancycode
fancycode approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@nickvergessen
Copy link
Member Author

Ran unit tests locally:

PHPUnit 8.5.9 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.12 with Xdebug 2.9.8
Configuration: /home/nickv/Nextcloud/21/server/appsbabies/spreed/tests/php/phpunit.xml

...............................................................  63 / 451 ( 13%)
............................................................... 126 / 451 ( 27%)
............................................................... 189 / 451 ( 41%)
............................................................... 252 / 451 ( 55%)
............................................................... 315 / 451 ( 69%)
............................................................... 378 / 451 ( 83%)
............................................................... 441 / 451 ( 97%)
..........                                                      451 / 451 (100%)

Time: 4.12 seconds, Memory: 40.00 MB

OK (451 tests, 1642 assertions)

@nickvergessen nickvergessen merged commit 879db89 into master Nov 27, 2020
@nickvergessen nickvergessen deleted the bugfix/noid/load-new-users-by-actor-when-session-does-not-exist-yet branch November 27, 2020 10:32
@nickvergessen
Copy link
Member Author

Backport added to #4612

@nickvergessen nickvergessen mentioned this pull request Nov 30, 2020
Merged
@nickvergessen nickvergessen mentioned this pull request Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fancycode fancycode fancycode approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: call 📹 Voice and video calls feature: SFU & SIP ☎️
Projects
None yet
Milestone
v11.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @fancycode