-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new app settings components #4195
Conversation
marcoambrosini
commented
Sep 22, 2020
•
edited
Loading
edited
- Requires App Settings Dialog nextcloud-libraries/nextcloud-vue#1286
e7f6520
to
7c00f8d
Compare
a06124f
to
67fa2c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error appears now in the browser console when opening the main Talk UI (even if the settings dialog is not opened):
[Vue warn]: Error in updated hook: "TypeError: this.$el.querySelector is not a function"
found in
---> <AppSettingsDialog>
<SettingsDialog> at src/components/SettingsDialog/SettingsDialog.vue
<Content>
<App> at src/App.vue
<Root>
Additionally, clicking on the headers in the left area causes the right area to scroll to the appropriate section, but scrolling in the right area does not change the highlighted header in the left area (although this may be an issue of the component from nextcloud-vue, I do not know).
I have also noticed that content in the right area can not be selected using the mouse (not that I want to, but I found it strange :-P ) and, in Firefox, it is not possible to scroll in the right area using the arrow keys (although it works in Chromium). However it also happened before using the new AppSettings components, so it could be a problem with the Modal component (just a guess). Opened issues in nextcloud-vue
.
cf9bfb7
to
33e1d94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with nextcloud-libraries/nextcloud-vue#1503, but there is still something strange with the blurring (not sure if the issue is in the component or in how it is used):
- Open the settings
- Close the settings
- Open the settings
- Click on the second header
- Scroll
The header will not be blurred.
seems this was closed by mistake |
please note that nextcloud-vue was updated, so many stuff that wasn't working before is working now. |
33e1d94
to
4baf560
Compare
Ready for review! |
a wild conflict appears! |
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
4baf560
to
c26bd7a
Compare
Rebased!! |