Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Allow to edit messages of bots in one-to-one conversations #14344

Merged

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 11, 2025

πŸ› οΈ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: chat πŸ’¬ Chat and system messages feature: api πŸ› οΈ OCS API for conversations, chats and participants feature: bots πŸ€– /commands in chat messages labels Feb 11, 2025
@nickvergessen nickvergessen self-assigned this Feb 11, 2025
@nickvergessen
Copy link
Member Author

Do we need a capability and explicit documentation, or should we just assume it is a bug fix and if editing fails because the client was already updated but the server not, we don't care?

@nickvergessen
Copy link
Member Author

/backport to stable31

@nickvergessen
Copy link
Member Author

/backport to stable30

@nickvergessen
Copy link
Member Author

/backport to stable29

@SystemKeeper
Copy link
Contributor

Do we need a capability and explicit documentation, or should we just assume it is a bug fix and if editing fails because the client was already updated but the server not, we don't care?

We need to change it on client side as well:

https://github.com/nextcloud/talk-ios/blob/fc5a9ebda821f257dddc73ec7169fcbc9f544571/NextcloudTalk/NCChatMessage.swift#L80-L83

But I would say we just enable it server-side and don't care if it wasn't updated.

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a capability and explicit documentation

'edit-messages' should be enough, if we backport it to 29?

@nickvergessen nickvergessen merged commit f9958b2 into main Feb 11, 2025
79 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/allow-to-edit-bot-messages-in-one-to-one branch February 11, 2025 14:54
Copy link

backportbot bot commented Feb 11, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/14344/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a3e3f28e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/14344/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api πŸ› οΈ OCS API for conversations, chats and participants feature: bots πŸ€– /commands in chat messages feature: chat πŸ’¬ Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants