-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chat): Allow to edit messages of bots in one-to-one conversations #14344
fix(chat): Allow to edit messages of bots in one-to-one conversations #14344
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Do we need a capability and explicit documentation, or should we just assume it is a bug fix and if editing fails because the client was already updated but the server not, we don't care? |
/backport to stable31 |
/backport to stable30 |
/backport to stable29 |
We need to change it on client side as well: But I would say we just enable it server-side and don't care if it wasn't updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a capability and explicit documentation
'edit-messages' should be enough, if we backport it to 29?
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/14344/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a3e3f28e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/14344/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
π οΈ API Checklist
π Checklist
docs/
has been updated or is not required