Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PresenterOverlay): fix RTL check #14329

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix(PresenterOverlay): fix RTL check #14329

merged 2 commits into from
Feb 10, 2025

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix regression after RTL changes
    • isRTL is a function, so direct check without calling returns true`
    • Dropped some resize listeners, as they are not used, or duplicating ResizeObserver functionality

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
2025-02-10_11h44_33 2025-02-10_11h44_54

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Feb 10, 2025
@Antreesy Antreesy requested a review from ShGKme February 10, 2025 10:47
@Antreesy Antreesy self-assigned this Feb 10, 2025
@Antreesy
fix(PresenterOverlay): fix RTL check
49e315a 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: drop redundant resize listeners
ea54046 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/rtl-presenter branch from 881eff6 to ea54046 Compare February 10, 2025 11:32
@Antreesy Antreesy enabled auto-merge February 10, 2025 11:32
@Antreesy
Copy link
Contributor Author

/backport to stable31

@Antreesy Antreesy merged commit b235658 into main Feb 10, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/noid/rtl-presenter branch February 10, 2025 11:35
@backportbot backportbot bot mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @ShGKme