Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable31] fix(i18n): align 'importListDescription' format and example in string #14244

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[stable31] fix(i18n): align 'importListDescription' format and example in string #14244

merged 1 commit into from
Feb 10, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 29, 2025

Backport of PR #14208

@Antreesy @backportbot
fix(i18n): align 'importListDescription' format and example in string
9c9b693 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@backportbot backportbot bot requested review from DorraJaouad and Antreesy January 29, 2025 09:33
@backportbot backportbot bot added this to the 🌿 Next RC (31) milestone Jan 29, 2025
Antreesy
Antreesy requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String freeze

@nickvergessen
Copy link
Member

its merged in main already so translators see the string already and don't know whether it is required for 31

@Antreesy
Copy link
Contributor

whether it is required for 31

Nevertheless, I'd postpone it until most languages are done, and merge right before releases

Antreesy
Antreesy approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 out of 15 languages are translated, so I think, we can get this in already

@Antreesy Antreesy merged commit f6c8851 into stable31 Feb 10, 2025
53 checks passed
@Antreesy Antreesy deleted the backport/14208/stable31 branch February 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v21.0.0-rc.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Antreesy