Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(team): support team mentions on frontend #14242

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix(team): support team mentions on frontend #14242

merged 2 commits into from
Jan 30, 2025

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • isCurrentUserTeam requires to be handled somehow with backend
  • displayName is supposed to be passed from backend

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Jan 28, 2025
@Antreesy Antreesy requested a review from DorraJaouad January 28, 2025 17:18
@Antreesy Antreesy self-assigned this Jan 28, 2025
@Antreesy Antreesy force-pushed the feat/12036/team-mentions-frontend branch from be530fb to 72d84be Compare January 30, 2025 14:26
@Antreesy
fix(LeftSidebar): define size property for groups and teams
3125abe 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(team): support team mentions on frontend
97d8cdb 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/12036/team-mentions-frontend branch from 72d84be to 97d8cdb Compare January 30, 2025 15:49
nickvergessen
nickvergessen approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@nickvergessen nickvergessen merged commit 57ac9b6 into main Jan 30, 2025
53 checks passed
@nickvergessen nickvergessen deleted the feat/12036/team-mentions-frontend branch January 30, 2025 18:17
@nickvergessen
Copy link
Member

/backport to stable31

@backportbot backportbot bot mentioned this pull request Jan 30, 2025
Merged
1 task
@SystemKeeper SystemKeeper mentioned this pull request Jan 30, 2025
Open
@nickvergessen nickvergessen mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @nickvergessen